r85840 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85839‎ | r85840 | r85841 >
Date:00:16, 12 April 2011
Author:reedy
Status:ok
Tags:
Comment:
Whitespace, braces, documentation
Modified paths:
  • /trunk/extensions/TitleBlacklist/TitleBlacklist.list.php (modified) (history)
  • /trunk/phase3/includes/filerepo/File.php (modified) (history)
  • /trunk/phase3/includes/media/GIF.php (modified) (history)
  • /trunk/phase3/maintenance/rebuildImages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/rebuildImages.php
@@ -33,6 +33,12 @@
3434 require_once( dirname( __FILE__ ) . '/Maintenance.php' );
3535
3636 class ImageBuilder extends Maintenance {
 37+
 38+ /**
 39+ * @var DatabaseBase
 40+ */
 41+ protected $dbw;
 42+
3743 function __construct() {
3844 parent::__construct();
3945
Index: trunk/phase3/includes/filerepo/File.php
@@ -1331,8 +1331,9 @@
13321332
13331333 function getRedirectedTitle() {
13341334 if ( $this->redirected ) {
1335 - if ( !$this->redirectTitle )
 1335+ if ( !$this->redirectTitle ) {
13361336 $this->redirectTitle = Title::makeTitle( NS_FILE, $this->redirected );
 1337+ }
13371338 return $this->redirectTitle;
13381339 }
13391340 }
Index: trunk/phase3/includes/media/GIF.php
@@ -39,8 +39,8 @@
4040 */
4141 function getImageArea( $image, $width, $height ) {
4242 $ser = $image->getMetadata();
43 - if ($ser) {
44 - $metadata = unserialize($ser);
 43+ if ( $ser ) {
 44+ $metadata = unserialize( $ser );
4545 return $width * $height * $metadata['frameCount'];
4646 } else {
4747 return $width * $height;
@@ -53,7 +53,7 @@
5454 */
5555 function isAnimatedImage( $image ) {
5656 $ser = $image->getMetadata();
57 - if ($ser) {
 57+ if ( $ser ) {
5858 $metadata = unserialize($ser);
5959 if( $metadata['frameCount'] > 1 ) {
6060 return true;
Index: trunk/extensions/TitleBlacklist/TitleBlacklist.list.php
@@ -299,7 +299,7 @@
300300 }
301301
302302 /**
303 - * Check whether a user can perform the specified action
 303+ * Check whether a user can perform the specified action
304304 * on the specified Title
305305 *
306306 * @param $title Title to check
@@ -404,7 +404,7 @@
405405 return null;
406406 }
407407 }
408 -
 408+
409409 /**
410410 * @returns This entry's regular expression
411411 */
@@ -432,7 +432,7 @@
433433 public function getCustomMessage() {
434434 return isset( $this->mParams['errmsg'] ) ? $this->mParams['errmsg'] : null;
435435 }
436 -
 436+
437437 /**
438438 * @returns The format version
439439 */
@@ -444,7 +444,7 @@
445445 * @param $v New version to set
446446 */
447447 public function setFormatVersion( $v ) { $this->mFormatVersion = $v; }
448 -
 448+
449449 /**
450450 * Return the error message name for the blacklist entry.
451451 *

Status & tagging log