r85812 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85811‎ | r85812 | r85813 >
Date:18:37, 11 April 2011
Author:reedy
Status:ok
Tags:
Comment:
Revert r85799
Modified paths:
  • /trunk/phase3/includes/LinksUpdate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LinksUpdate.php
@@ -345,22 +345,15 @@
346346 $where = false;
347347 }
348348 }
349 -
350 - // Create and use a new loadBalancer object, to prevent "1205: Lock wait timeout exceeded;"
351 - $lb = wfGetLBFactory()->newMainLB();
352 - $dbw = $lb->getConnection( DB_MASTER );
353 -
354349 if ( $where ) {
355 - $dbw->delete( $table, $where, __METHOD__ );
 350+ $this->mDb->delete( $table, $where, __METHOD__ );
356351 }
357352 if ( count( $insertions ) ) {
358 - $dbw->insert( $table, $insertions, __METHOD__, 'IGNORE' );
 353+ $this->mDb->insert( $table, $insertions, __METHOD__, 'IGNORE' );
359354 }
360 -
361 - $lb->commitMasterChanges();
362 - $lb->closeAll();
363355 }
364356
 357+
365358 /**
366359 * Get an array of pagelinks insertions for passing to the DB
367360 * Skips the titles specified by the 2-D array $existing

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85799commons.wikimedia: (SQL Query hidden) from within function "LinksUpdate::incr...reedy16:42, 11 April 2011

Status & tagging log