r85801 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85800‎ | r85801 | r85802 >
Date:16:52, 11 April 2011
Author:ialex
Status:ok
Tags:
Comment:
No need to call wfSuppressWarnings() and wfRestoreWarnings(); wfDl() already does this
Modified paths:
  • /trunk/phase3/includes/diff/DifferenceEngine.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/diff/DifferenceEngine.php
@@ -697,16 +697,12 @@
698698 global $wgExternalDiffEngine;
699699 if ( $wgExternalDiffEngine == 'wikidiff' && !function_exists( 'wikidiff_do_diff' ) ) {
700700 wfProfileIn( __METHOD__ . '-php_wikidiff.so' );
701 - wfSuppressWarnings();
702701 wfDl( 'php_wikidiff' );
703 - wfRestoreWarnings();
704702 wfProfileOut( __METHOD__ . '-php_wikidiff.so' );
705703 }
706704 else if ( $wgExternalDiffEngine == 'wikidiff2' && !function_exists( 'wikidiff2_do_diff' ) ) {
707705 wfProfileIn( __METHOD__ . '-php_wikidiff2.so' );
708 - wfSuppressWarnings();
709706 wfDl( 'wikidiff2' );
710 - wfRestoreWarnings();
711707 wfProfileOut( __METHOD__ . '-php_wikidiff2.so' );
712708 }
713709 }

Status & tagging log