r85789 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85788‎ | r85789 | r85790 >
Date:13:53, 11 April 2011
Author:reedy
Status:ok
Tags:
Comment:
Remove unused globals
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)
  • /trunk/phase3/maintenance/rebuildFileCache.php (modified) (history)
  • /trunk/phase3/maintenance/refreshLinks.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/rebuildFileCache.php
@@ -33,7 +33,7 @@
3434
3535 public function execute() {
3636 global $wgUseFileCache, $wgDisableCounters, $wgContentNamespaces, $wgRequestTime;
37 - global $wgTitle, $wgArticle, $wgOut, $wgUser;
 37+ global $wgTitle, $wgArticle, $wgOut;
3838 if ( !$wgUseFileCache ) {
3939 $this->error( "Nothing to do -- \$wgUseFileCache is disabled.", true );
4040 }
Index: trunk/phase3/maintenance/refreshLinks.php
@@ -60,7 +60,7 @@
6161 */
6262 private function doRefreshLinks( $start, $newOnly = false, $maxLag = false,
6363 $end = 0, $redirectsOnly = false, $oldRedirectsOnly = false ) {
64 - global $wgUser, $wgParser, $wgUseTidy;
 64+ global $wgParser, $wgUseTidy;
6565
6666 $reportingInterval = 100;
6767 $dbr = wfGetDB( DB_SLAVE );
Index: trunk/phase3/includes/OutputPage.php
@@ -2358,8 +2358,7 @@
23592359 * @return String: The doctype, opening <html>, and head element.
23602360 */
23612361 public function headElement( Skin $sk, $includeStyle = true ) {
2362 - global $wgOutputEncoding, $wgMimeType;
2363 - global $wgUseTrackbacks, $wgHtml5;
 2362+ global $wgUseTrackbacks;
23642363
23652364 if ( $sk->commonPrintStylesheet() ) {
23662365 $this->addModuleStyles( 'mediawiki.legacy.wikiprintable' );

Status & tagging log