r85782 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r85781
|
r85782
|
r85783
>
Date:
12:48, 11 April 2011
Author:
reedy
Status:
reverted
Tags:
Comment:
Followup
r85776
, per Aaron, add documentation showing reason why explicit creation of a new LB was added
Modified paths:
/trunk/phase3/includes/Block.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/phase3/includes/Block.php
—
—
@@ -889,6 +889,8 @@
890
890
* Purge expired blocks from the ipblocks table
891
891
*/
892
892
public static function purgeExpired() {
893
+ // https://bugzilla.wikimedia.org/show_bug.cgi?id=28485
894
+ // Create and use a new loadBalancer object, to prevent "1205: Lock wait timeout exceeded;"
893
895
$lb = wfGetLBFactory()->newMainLB();
894
896
$dbw = $lb->getConnection( DB_MASTER );
895
897
Follow-up revisions
Revision
Commit summary
Author
Date
r85916
Revert
r85776
,
r85782
pending better solution
reedy
20:27, 12 April 2011
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r85776
* (
bug 28485
) Block::purgeExpired Database returned error "1205: Lock wait ti...
reedy
00:29, 11 April 2011
Status & tagging log
20:28, 12 April 2011
Reedy
(
talk
|
contribs
)
changed the
tags
for r85782
[
removed:
1.17,1.17wmf1]
20:28, 12 April 2011
Reedy
(
talk
|
contribs
)
changed the
status
of r85782
[
removed:
new
added:
reverted]
16:43, 11 April 2011
Reedy
(
talk
|
contribs
)
changed the
tags
for r85782
[
added:
1.17,1.17wmf1]