r85774 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85773‎ | r85774 | r85775 >
Date:22:27, 10 April 2011
Author:neilk
Status:ok
Tags:
Comment:
followup to r85654, move global declarations
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/api/RandomImageGenerator.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/api/RandomImageGenerator.php
@@ -35,7 +35,6 @@
3636 private $imageWriteMethod;
3737
3838 public function __construct( $options = array() ) {
39 - global $wgUseImageMagick, $wgImageMagickConvertCommand;
4039 foreach ( array( 'dictionaryFile', 'minWidth', 'minHeight', 'maxHeight', 'circlesToDraw' ) as $property ) {
4140 if ( isset( $options[$property] ) ) {
4241 $this->$property = $options[$property];
@@ -79,6 +78,7 @@
8079 * @param $format (a typical extension like 'svg', 'jpg', etc.)
8180 */
8281 function getImageWriteMethod( $format ) {
 82+ global $wgUseImageMagick, $wgImageMagickConvertCommand;
8383 if ( $format === 'svg' ) {
8484 return 'writeSvg';
8585 } else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85654also generate random SVG filesneilk23:32, 7 April 2011

Status & tagging log