r85763 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85762‎ | r85763 | r85764 >
Date:17:19, 10 April 2011
Author:aaron
Status:ok
Tags:
Comment:
Removed unused $title param from stabilizeParserOutput
Modified paths:
  • /trunk/extensions/FlaggedRevs/FRInclusionManager.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.class.php
@@ -512,7 +512,7 @@
513513 if ( !$incManager->parserOutputIsStabilized() ) {
514514 $frev = FlaggedRevision::newFromTitle( $title, $id );
515515 if ( $frev ) {
516 - $incManager->stabilizeParserOutput( $title, $frev );
 516+ $incManager->stabilizeParserOutput( $frev );
517517 $resetManager = true; // need to reset when done
518518 }
519519 }
@@ -546,7 +546,7 @@
547547 if ( !$incManager->parserOutputIsStabilized() ) {
548548 $frev = FlaggedRevision::newFromTitle( $title, $id );
549549 if ( $frev ) {
550 - $incManager->stabilizeParserOutput( $title, $frev );
 550+ $incManager->stabilizeParserOutput( $frev );
551551 $resetManager = true; // need to reset when done
552552 }
553553 }
Index: trunk/extensions/FlaggedRevs/FRInclusionManager.php
@@ -94,14 +94,13 @@
9595
9696 /**
9797 * (a) Stabilize inclusions in Parser output
98 - * (b) Load all of the "at review time" versions of template/files
 98+ * (b) Load all of the "review time" versions of template/files from $frev
9999 * (c) Load their stable version counterparts (avoids DB hits)
100100 * Note: Used when calling FlaggedRevs::parseStableText().
101 - * @param Title $title
102101 * @param FlaggedRevision $frev
103102 * @return void
104103 */
105 - public function stabilizeParserOutput( Title $title, FlaggedRevision $frev ) {
 104+ public function stabilizeParserOutput( FlaggedRevision $frev ) {
106105 $tStbVersions = $fStbVersions = array(); // stable versions
107106 $tRevVersions = $frev->getTemplateVersions();
108107 $fRevVersions = $frev->getFileVersions();

Status & tagging log