r85753 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85752‎ | r85753 | r85754 >
Date:08:48, 10 April 2011
Author:maxsem
Status:ok
Tags:
Comment:
1.17: MFT r85752 (MySQL --> SQLite compatibility tweak)
Modified paths:
  • /branches/REL1_17/phase3 (modified) (history)
  • /branches/REL1_17/phase3/includes (modified) (history)
  • /branches/REL1_17/phase3/includes/db (modified) (history)
  • /branches/REL1_17/phase3/includes/db/DatabaseSqlite.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/db/DatabaseSqlite.php
@@ -584,6 +584,8 @@
585585 $s = preg_replace( '/\bauto_increment\b/i', 'AUTOINCREMENT', $s );
586586 // No explicit options
587587 $s = preg_replace( '/\)[^);]*(;?)\s*$/', ')\1', $s );
 588+ // AUTOINCREMENT should immedidately follow PRIMARY KEY
 589+ $s = preg_replace( '/primary key (.*?) autoincrement/i', 'PRIMARY KEY AUTOINCREMENT $1', $s );
588590 } elseif ( preg_match( '/^\s*CREATE (\s*(?:UNIQUE|FULLTEXT)\s+)?INDEX/i', $s ) ) {
589591 // No truncated indexes
590592 $s = preg_replace( '/\(\d+\)/', '', $s );
Property changes on: branches/REL1_17/phase3/includes/db
___________________________________________________________________
Modified: svn:mergeinfo
591593 Merged /trunk/phase3/includes/db:r85752
Property changes on: branches/REL1_17/phase3/includes
___________________________________________________________________
Modified: svn:mergeinfo
592594 Merged /trunk/phase3/includes:r85752
Property changes on: branches/REL1_17/phase3
___________________________________________________________________
Modified: svn:mergeinfo
593595 Merged /trunk/phase3:r85752

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85752SQLite is picky about the position of AUTOINCREMENT in field definition, hand...maxsem08:44, 10 April 2011

Status & tagging log