r85659 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85658‎ | r85659 | r85660 >
Date:05:26, 8 April 2011
Author:kaldari
Status:deferred
Tags:
Comment:
removing delay on initial spinner per Erik
Modified paths:
  • /trunk/extensions/UploadWizard/SpecialUploadWizard.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/SpecialUploadWizard.php
@@ -195,16 +195,9 @@
196196 // if loading takes > 2 seconds display spinner. Note we are evading Resource Loader here, and linking directly. Because we want an image to appear if RL's package is late.
197197 // using some  's which is a bit of superstition, to make sure jQuery will hide this (it seems that it doesn't sometimes, when it has no content)
198198 // the min-width & max-width is copied from the #uploadWizard properties, so in nice browsers the spinner is right where the button will go.
199 - . '<div id="mwe-first-spinner" style="visibility:hidden; min-width:750px; max-width:900px; height:200px; line-height:200px; text-align:center;">&nbsp;</div>'
200 - . '<script language="JavaScript">'
201 - . 'window.setTimeout( function() {'
202 - . 'var s = document.getElementById( "mwe-first-spinner" );'
203 - . 'if (s) {'
204 - . 's.innerHTML = "&nbsp;<img src=\\"' . $wgExtensionAssetsPath . '/UploadWizard/resources/images/24px-spinner-0645ad.gif\\" width=\\"24\\" height=\\"24\\" />&nbsp;";'
205 - . 's.style.visibility = "visible";'
206 - . '}'
207 - . '}, 2000)'
208 - . '</script>'
 199+ . '<div id="mwe-first-spinner" style="min-width:750px; max-width:900px; height:200px; line-height:200px; text-align:center;">'
 200+ . '&nbsp;<img src="' . $wgExtensionAssetsPath . '/UploadWizard/resources/images/24px-spinner-0645ad.gif" width="24" height="24" />&nbsp;'
 201+ . '</div>'
209202
210203 // the arrow steps - hide until styled
211204 . '<ul id="mwe-upwiz-steps" style="display:none;">'

Status & tagging log