r85648 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85647‎ | r85648 | r85649 >
Date:22:04, 7 April 2011
Author:kaldari
Status:deferred
Tags:
Comment:
preparing for new thumbnail linking system
Modified paths:
  • /trunk/extensions/UploadWizard/resources/mw.UploadWizard.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/mw.UploadWizard.js
@@ -211,12 +211,6 @@
212212 mw.UploadWizard.config[ 'iconThumbnailWidth' ],
213213 mw.UploadWizard.config[ 'iconThumbnailMaxHeight' ]
214214 );
215 - // create the large thumbnail that the other thumbnails link to
216 - _this.getThumbnail(
217 - function( image ) {},
218 - mw.UploadWizard.config[ 'largeThumbnailWidth' ],
219 - mw.UploadWizard.config[ 'largeThumbnailMaxHeight' ]
220 - );
221215 _this.deedPreview.setup();
222216 _this.details.populate();
223217 _this.state = 'stashed';
@@ -412,23 +406,14 @@
413407 height = parseInt( height, 10 );
414408 }
415409
416 - var href = '#';
417 - $j.each( [ 'descriptionurl', 'url' ], function( i, propName ) {
418 - var prop = _this.imageinfo[ propName ];
419 - if ( prop ) {
420 - href = prop;
421 - return false;
422 - }
423 - } );
424 -
425410 var callback = function( image ) {
426411 if ( image === null ) {
427412 $j( selector ).addClass( 'mwe-upwiz-file-preview-broken' );
428413 _this.ui.setStatus( 'mwe-upwiz-thumbnail-failed' );
429414 } else {
430415 $j( selector ).html(
431 - $j( '<a/>' )
432 - .attr( { 'href': href,
 416+ $j( '<a class="mwe-upwiz-thumbnail-link"></a>' )
 417+ .attr( { 'href': '#',
433418 'target' : '_new' } )
434419 .append(
435420 $j( '<img/>' )

Follow-up revisions

RevisionCommit summaryAuthorDate
r85655fix for Bug 28316kaldari00:45, 8 April 2011

Status & tagging log