r85615 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85614‎ | r85615 | r85616 >
Date:11:08, 7 April 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17: Undo botched merge of r84985 in 85435, was causing JS errors
Modified paths:
  • /branches/REL1_17/phase3/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/resources/mediawiki/mediawiki.js
@@ -606,12 +606,8 @@
607607 }
608608 }
609609 } catch ( e ) {
610 - // This needs to NOT use mw.log because these errors are common in production mode
611 - // and not in debug mode, such as when a symbol that should be global isn't exported
612 - if ( window.console && typeof window.console.log === 'function' ) {
613 - console.log( _fn + 'Exception thrown by ' + module + ': ' + e.message );
614 - console.log( e );
615 - }
 610+ mediaWiki.log( 'Exception thrown by ' + module + ': ' + e.message );
 611+ mediaWiki.log( e );
616612 registry[module].state = 'error';
617613 // Run error callbacks of jobs affected by this condition
618614 for ( var j = 0; j < jobs.length; j++ ) {
Property changes on: branches/REL1_17/phase3/resources/mediawiki/mediawiki.js
___________________________________________________________________
Modified: svn:mergeinfo
619615 Reverse-merged /trunk/phase3/resources/mediawiki/mediawiki.js:r84431,84464,84543,84553,84573-84574,84577,84579,84729,84765,84820,84846,84905,84985,85032,85140,85143,85152,85178,85194,85199

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84985Swtiched to using console.log if present so that when errors occur inside of ...tparscal22:08, 29 March 2011

Status & tagging log