r85570 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85569‎ | r85570 | r85571 >
Date:20:18, 6 April 2011
Author:krinkle
Status:deferred
Tags:
Comment:
Prettyfing the 'Tools using Tsint'-list and adding general messages for 'last-modified-date' and 'view-source'
Modified paths:
  • /trunk/tools/ToolserverI18N/language/messages/General.i18n.php (modified) (history)
  • /trunk/tools/ToolserverI18N/public_html/index.php (modified) (history)

Diff [purge]

Index: trunk/tools/ToolserverI18N/language/messages/General.i18n.php
@@ -24,6 +24,8 @@
2525 'weeks' => 'weeks',
2626 'days' => 'days',
2727 'hours' => 'hours',
 28+ 'last-modified-date' => 'Last modified: $1',
 29+ 'view-source' => 'View source',
2830 );
2931
3032 /** Message documentation (Message documentation)
@@ -39,6 +41,8 @@
4042 'namespace' => '{{Identical|Namespace}}',
4143 'form-submit' => 'A general label for a form submission button. Not per se a search form!',
4244 'form-reset' => 'A general label for a form reset button. Not per se a search form!',
 45+ 'last-modified-date' => 'The date something was last modified. $1 is a date (eg. "April 5 2010, 12:30 AM")',
 46+ 'view-source' => 'Label for a button or link that, when clicked, will present the program source code.',
4347 );
4448
4549 /** Bengali (বাংলা)
Index: trunk/tools/ToolserverI18N/public_html/index.php
@@ -251,8 +251,12 @@
252252 $domainInfo = $I18N->getDomainInfo( $domainKey );
253253 $title = $I18N->msg( 'title', $domainKey, /* fallback = */ $domainKey );
254254 if ( isset( $domainInfo['url'] ) ) {
255 - $item = TsIntuitionUtil::tag( "$title <{$domainInfo['url']}>", 'a', array( 'href' => $domainInfo['url'] ) );
256 - $about .= "<li>$item</li>";
 255+ $about .= '<li><a href="'
 256+ . htmlspecialchars( $domainInfo['url'] )
 257+ . '"><strong>' . htmlspecialchars( $title )
 258+ . '</strong><br />'
 259+ . htmlspecialchars( $domainInfo['path'] )
 260+ . '</a></li>';
257261 } else {
258262 // Don't show tools without a url
259263 //$item = TsIntuitionUtil::tag( $title, 'em' );

Status & tagging log