r85564 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85563‎ | r85564 | r85565 >
Date:19:39, 6 April 2011
Author:krinkle
Status:deferred
Tags:
Comment:
adding 'mode' option so LocalConfig can distinguish between in-tool and dashboard (fixes E_NOTICE and in some cases a fatal error due to function inexistance in custom scenarios (ie. my localhost / sandbox) - this should also fix the bug that putting svgtranslate down
Modified paths:
  • /trunk/tools/ToolserverI18N/TsIntuition.php (modified) (history)
  • /trunk/tools/ToolserverI18N/public_html/index.php (modified) (history)

Diff [purge]

Index: trunk/tools/ToolserverI18N/TsIntuition.php
@@ -33,6 +33,7 @@
3434 public $version = '0.1.2-svn';
3535 public $versionDate;
3636 public $publicHtmlPath = '/TsIntuition/';
 37+ public $mode = null; // 'in-tool', 'dashboard'
3738
3839 // Address to the dashboard home. Should end with a slash or .extension
3940 public $dashboardHome = 'http://toolserver.org/~krinkle/TsIntuition/';
@@ -116,6 +117,7 @@
117118 'suppressbrackets' => false,
118119 'stayalive' => false,
119120 'param' => true,
 121+ 'mode' => 'in-tool',
120122 );
121123 $options = array_merge( $defaultOptions, $options );
122124
Index: trunk/tools/ToolserverI18N/public_html/index.php
@@ -46,6 +46,7 @@
4747 'revisionId' => $I18N->version,
4848 'revisionDate' => $I18N->dateFormatted( $I18N->versionDate ),
4949 'styles' => array( 'main.css' ),
 50+ 'mode' => 'dashboard',
5051 );
5152
5253 $Tool = BaseTool::newFromArray( $opts );

Status & tagging log