r85552 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85551‎ | r85552 | r85553 >
Date:17:21, 6 April 2011
Author:tparscal
Status:ok
Tags:
Comment:
Added hidden origin question to survey, which is auto-filled with wgTitle.
Modified paths:
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js
@@ -109,6 +109,7 @@
110110 .button()
111111 .insertAfter( $input );
112112 $input.remove();
 113+ $form.find( '#prefswitch-survey-origin' ).text( mw.config.get( 'wgTitle' ) );
113114 // Take dialog out of loading state
114115 $dialog.removeClass( 'loading' );
115116 } );
Index: trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php
@@ -11,6 +11,7 @@
1212 'articlefeedback' => 'Article feedback',
1313 'articlefeedback-desc' => 'Article feedback',
1414 /* Survey Messages */
 15+ 'articlefeedback-survey-question-origin' => 'What page were you on when you started this survey?',
1516 'articlefeedback-survey-question-whyrated' => 'Please let us know why you rated this page today (check all that apply):',
1617 'articlefeedback-survey-answer-whyrated-contribute-rating' => 'I wanted to contribute to the overall rating of the page',
1718 'articlefeedback-survey-answer-whyrated-development' => 'I hope that my rating would positively affect the development of the page',
Index: trunk/extensions/ArticleFeedback/ArticleFeedback.php
@@ -40,6 +40,11 @@
4141 'updatable' => false,
4242 'submit-msg' => 'articlefeedback-survey-submit',
4343 'questions' => array(
 44+ 'origin' => array(
 45+ 'visibility' => 'hidden',
 46+ 'question' => 'articlefeedback-survey-question-origin',
 47+ 'type' => 'text',
 48+ ),
4449 'whyrated' => array(
4550 'question' => 'articlefeedback-survey-question-whyrated',
4651 'type' => 'checks',

Status & tagging log