r85492 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85491‎ | r85492 | r85493 >
Date:00:02, 6 April 2011
Author:ashley
Status:deferred
Tags:
Comment:
SocialProfile: wikilinks are prettier than raw HTML; also swapped a wfMsgForContent() to a regular wfMsg(), no reason to display an error message in the wiki's content language
Modified paths:
  • /trunk/extensions/SocialProfile/UserProfile/SpecialEditProfile.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserProfile/SpecialUpdateProfile.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserProfile/UserProfile.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SocialProfile/UserProfile/SpecialUpdateProfile.php
@@ -61,13 +61,8 @@
6262
6363 // This feature is only available for logged-in users.
6464 if ( !$wgUser->isLoggedIn() ) {
65 - $wgOut->setPageTitle( wfMsgForContent( 'user-profile-update-notloggedin-title' ) );
66 - $wgOut->addHTML(
67 - wfMsgForContent( 'user-profile-update-notloggedin-text',
68 - SpecialPage::getTitleFor( 'Userlogin' )->escapeFullURL(),
69 - SpecialPage::getTitleFor( 'Userlogin', 'signup' )->escapeFullURL()
70 - )
71 - );
 65+ $wgOut->setPageTitle( wfMsg( 'user-profile-update-notloggedin-title' ) );
 66+ $wgOut->addWikiMsg( 'user-profile-update-notloggedin-text' );
7267 return;
7368 }
7469
Index: trunk/extensions/SocialProfile/UserProfile/SpecialEditProfile.php
@@ -30,13 +30,8 @@
3131
3232 // This feature is only available for logged-in users.
3333 if ( !$wgUser->isLoggedIn() ) {
34 - $wgOut->setPageTitle( wfMsgForContent( 'user-profile-update-notloggedin-title' ) );
35 - $wgOut->addHTML(
36 - wfMsgForContent( 'user-profile-update-notloggedin-text',
37 - SpecialPage::getTitleFor( 'Userlogin' )->escapeFullURL(),
38 - SpecialPage::getTitleFor( 'Userlogin', 'signup' )->escapeFullURL()
39 - )
40 - );
 34+ $wgOut->setPageTitle( wfMsg( 'user-profile-update-notloggedin-title' ) );
 35+ $wgOut->addWikiMsg( 'user-profile-update-notloggedin-text' );
4136 return;
4237 }
4338
Index: trunk/extensions/SocialProfile/UserProfile/UserProfile.i18n.php
@@ -89,7 +89,7 @@
9090 'user-recent-system-gift' => 'Received an award',
9191 'user-profile-update-notloggedin-title' => 'Cannot edit your profile without being logged in',
9292 'user-profile-update-notloggedin-text' => 'You cannot edit your profile without being logged in.
93 -Click <a href="$1">here</a> to login or click <a href="$2">here</a> to register.',
 93+Click [[Special:UserLogin|here]] to login or click [[Special:UserLogin/signup|here]] to register.',
9494 'user-profile-update-saved' => 'Your profile has been saved',
9595 'user-profile-edit-profile-update-saved' => 'The user\'s profile was successfully saved',
9696 'user-profile-update-log-section' => 'changed section',

Status & tagging log