r85480 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85479‎ | r85480 | r85481 >
Date:22:34, 5 April 2011
Author:krinkle
Status:deferred
Tags:
Comment:
Hide General and possible other domains aren't real tools, also add #tab-settingsform to the backlink so that it jumps to the right tab
Modified paths:
  • /trunk/tools/ToolserverI18N/TsIntuition.php (modified) (history)
  • /trunk/tools/ToolserverI18N/public_html/index.php (modified) (history)

Diff [purge]

Index: trunk/tools/ToolserverI18N/TsIntuition.php
@@ -1050,7 +1050,7 @@
10511051 'returntoquery' => http_build_query( $_GET ),
10521052 );
10531053 $p = http_build_query( $p );
1054 - return "{$this->dashboardHome}?$p";
 1054+ return "{$this->dashboardHome}?$p#tab-settingsform";
10551055 }
10561056
10571057 /**
Index: trunk/tools/ToolserverI18N/public_html/index.php
@@ -255,10 +255,12 @@
256256 $domainInfo = $I18N->getDomainInfo( $domainKey );
257257 $title = $I18N->msg( 'title', $domainKey, /* fallback = */ $domainKey );
258258 if ( isset( $domainInfo['url'] ) ) {
259 - $link = TsIntuitionUtil::tag( $title, 'a', array( 'href' => $domainInfo['url'] ) );
260 - $about .= "<li>$link</li>";
 259+ $item = TsIntuitionUtil::tag( "$title <{$domainInfo['url']}>", 'a', array( 'href' => $domainInfo['url'] ) );
 260+ $about .= "<li>$item</li>";
261261 } else {
262 - $about .= TsIntuitionUtil::tag( $title, 'li' );
 262+ // Don't show tools without a url
 263+ //$item = TsIntuitionUtil::tag( $title, 'em' );
 264+ //$about .= "<li>$item</li>";
263265 }
264266 }
265267 $about .= '</ul><div style="clear:both"></div></div><!-- #tab-about -->';

Status & tagging log