r85332 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85331‎ | r85332 | r85333 >
Date:15:26, 4 April 2011
Author:happy-melon
Status:ok
Tags:
Comment:
Fix fatal in SpecialCite introduced in the Context rewrite. Reported on r85302 CR, but not sure which exact revision actually caused it.
Modified paths:
  • /trunk/extensions/Cite/SpecialCite.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Cite/SpecialCite.php
@@ -36,7 +36,7 @@
3737 function wfSpecialCiteNav( &$skintemplate, &$nav_urls, &$oldid, &$revid ) {
3838 // check whether we’re in the right namespace, the $revid has the correct type and is not empty
3939 // (what would mean that the current page doesn’t exist)
40 - if ( $skintemplate->mTitle->isContentPage() && $revid !== 0 && !empty( $revid ) )
 40+ if ( $skintemplate->getTitle()->isContentPage() && $revid !== 0 && !empty( $revid ) )
4141 $nav_urls['cite'] = array(
4242 'args' => "page=" . wfUrlencode( "{$skintemplate->thispage}" ) . "&id=$revid"
4343 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85302Instead of creating an OutputPage and then setting a context start initializi...dantman00:37, 4 April 2011

Status & tagging log