r85321 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85320‎ | r85321 | r85322 >
Date:10:26, 4 April 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
Don't use syck-pecl for dumping, the output is horrible
Modified paths:
  • /trunk/extensions/Translate/utils/TranslateYaml.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/utils/TranslateYaml.php
@@ -108,10 +108,11 @@
109109 case 'spyc':
110110 require_once( dirname( __FILE__ ) . '/../spyc/spyc.php' );
111111 return Spyc::YAMLDump( $text );
 112+ case 'syck-pecl':
 113+ // Just horrible output
 114+ //return syck_dump( $text );
112115 case 'syck':
113116 return self::syckDump( $text );
114 - case 'syck-pecl':
115 - return syck_dump( $text );
116117 default:
117118 throw new MWException( "Unknown Yaml library" );
118119 }

Status & tagging log