r85312 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85311‎ | r85312 | r85313 >
Date:05:25, 4 April 2011
Author:aaron
Status:ok
Tags:
Comment:
Make sure the basic CSS still loads even with JS disabled
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -344,6 +344,10 @@
345345 $remoteModulePath = 'FlaggedRevs/modules';
346346 $wgResourceModules['ext.flaggedRevs.basic'] = array(
347347 'styles' => array( 'flaggedrevs.css' ),
 348+ 'localBasePath' => $localModulePath,
 349+ 'remoteExtPath' => $remoteModulePath,
 350+);
 351+$wgResourceModules['ext.flaggedRevs.advanced'] = array(
348352 'scripts' => array( 'flaggedrevs.js' ),
349353 'messages' => array(
350354 'revreview-toggle-show', 'revreview-toggle-hide',
@@ -369,7 +373,7 @@
370374 'remoteExtPath' => $remoteModulePath,
371375 );
372376
373 -# ####### HOOK TRIGGERED FUNCTIONS #########
 377+# ####### EVENT-HANDLER FUNCTIONS #########
374378
375379 # ######## User interface #########
376380 # Override current revision, add patrol links, set cache...
Index: trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php
@@ -56,7 +56,8 @@
5757 return true;
5858 }
5959 # Add main CSS & JS files
60 - $wgOut->addModules( 'ext.flaggedRevs.basic' );
 60+ $wgOut->addModuleStyles( 'ext.flaggedRevs.basic' );
 61+ $wgOut->addModules( 'ext.flaggedRevs.advanced' );
6162 # Add review form JS for reviewers
6263 if ( $wgUser->isAllowed( 'review' ) ) {
6364 $wgOut->addModules( 'ext.flaggedRevs.review' );

Status & tagging log