r85310 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85309‎ | r85310 | r85311 >
Date:03:42, 4 April 2011
Author:tstarling
Status:ok
Tags:
Comment:
Fix for r85244: HipHop does not support the static form of method_exists().
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -1554,8 +1554,9 @@
15551555 * @param $args Array Arguments to the method
15561556 */
15571557 function __call( $fname, $args ) {
1558 - if ( method_exists( 'Linker', $fname ) ) {
1559 - return call_user_func_array( array( 'Linker', $fname ), $args );
 1558+ $realFunction = array( 'Linker', $fname );
 1559+ if ( is_callable( $realFunction ) ) {
 1560+ return call_user_func_array( $realFunction, $args );
15601561 } else {
15611562 $className = get_class( $this );
15621563 throw new MWException( "Call to undefined method $className::$fname" );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85244Drop connetion between Skin and Linker and turn Linker into a staticly usable...dantman11:44, 3 April 2011

Status & tagging log