r85303 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85302‎ | r85303 | r85304 >
Date:00:42, 4 April 2011
Author:dantman
Status:ok
Tags:
Comment:
Remove a dead patch of Skin code that was migrated completely into SkinLegacy and SkinTemplate already.
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -323,40 +323,9 @@
324324 /**
325325 * Outputs the HTML generated by other functions.
326326 * @param $out Object: instance of OutputPage
327 - * @todo Exterminate!
328327 */
329 - function outputPage( OutputPage $out ) {
330 - global $wgDebugComments;
331 - wfProfileIn( __METHOD__ );
 328+ abstract function outputPage( OutputPage $out );
332329
333 - $this->initPage( $out );
334 -
335 - // See self::afterContentHook() for documentation
336 - $afterContent = $this->afterContentHook();
337 -
338 - $out->out( $out->headElement( $this ) );
339 -
340 - if ( $wgDebugComments ) {
341 - $out->out( "<!-- Debug output:\n" .
342 - $out->mDebugtext . "-->\n" );
343 - }
344 -
345 - $out->out( $this->beforeContent() );
346 -
347 - $out->out( $out->mBodytext . "\n" );
348 -
349 - $out->out( $this->afterContent() );
350 -
351 - $out->out( $afterContent );
352 -
353 - $out->out( $this->bottomScripts( $out ) );
354 -
355 - $out->out( wfReportTime() );
356 -
357 - $out->out( "\n</body></html>" );
358 - wfProfileOut( __METHOD__ );
359 - }
360 -
361330 static function makeVariablesScript( $data ) {
362331 if ( $data ) {
363332 return Html::inlineScript(

Status & tagging log