r85297 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85296‎ | r85297 | r85298 >
Date:23:38, 3 April 2011
Author:dantman
Status:ok
Tags:
Comment:
Fix use of mUser noted by c15657 on r85250.
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -252,6 +252,14 @@
253253 return $this->getContext()->getTitle();
254254 }
255255
 256+ /** Get the user
 257+ *
 258+ * @return User
 259+ */
 260+ public function getUser() {
 261+ return $this->getContext()->getUser();
 262+ }
 263+
256264 /**
257265 * Set the "relevant" title
258266 * @see self::getRelevantTitle()
@@ -1363,7 +1371,7 @@
13641372 $ntl = '';
13651373
13661374 if ( count( $newtalks ) == 1 && $newtalks[0]['wiki'] === wfWikiID() ) {
1367 - $userTitle = $this->mUser->getUserPage();
 1375+ $userTitle = $this->getUser()->getUserPage();
13681376 $userTalkTitle = $userTitle->getTalkPage();
13691377
13701378 if ( !$userTalkTitle->equals( $out->getTitle() ) ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85250Continue with r85240; Move getSkin from User to RequestContext, do it without...dantman12:46, 3 April 2011

Status & tagging log