r85281 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85280‎ | r85281 | r85282 >
Date:20:55, 3 April 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
follow up to r85250
Modified paths:
  • /trunk/extensions/Push/Push.php (modified) (history)
  • /trunk/extensions/Push/RELEASE-NOTES (modified) (history)
  • /trunk/extensions/Push/includes/Push_Tab.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Push/Push.php
@@ -25,7 +25,7 @@
2626 die( 'Not an entry point.' );
2727 }
2828
29 -define( 'Push_VERSION', '0.8' );
 29+define( 'Push_VERSION', '0.9 alpha' );
3030
3131 $wgExtensionCredits['other'][] = array(
3232 'path' => __FILE__,
Index: trunk/extensions/Push/RELEASE-NOTES
@@ -4,6 +4,10 @@
55 Latest version of the release notes: http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/Push/RELEASE-NOTES?view=co
66
77
 8+=== Version 0.9 ===
 9+
 10+* Fixed compatibility with MediaWiki 1.18.
 11+
812 === Version 0.8 ===
913 2011-02-27
1014
Index: trunk/extensions/Push/includes/Push_Tab.php
@@ -19,9 +19,10 @@
2020 global $wgUser, $egPushTargets;
2121
2222 // Make sure that this is not a special page, the page has contents, and the user can push.
23 - if (isset( $obj->mTitle )
24 - && $obj->mTitle->getNamespace() != NS_SPECIAL
25 - && $obj->mTitle->exists()
 23+ $title = $obj->getTitle();
 24+ if (
 25+ $title->getNamespace() != NS_SPECIAL
 26+ && $title->exists()
2627 && $wgUser->isAllowed( 'push' )
2728 && count( $egPushTargets ) > 0 ) {
2829
@@ -30,7 +31,7 @@
3132 $content_actions['push'] = array(
3233 'text' => wfMsg( 'push-tab-text' ),
3334 'class' => $wgRequest->getVal( 'action' ) == 'push' ? 'selected' : '',
34 - 'href' => $obj->mTitle->getLocalURL( 'action=push' )
 35+ 'href' => $title->getLocalURL( 'action=push' )
3536 );
3637 }
3738

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85250Continue with r85240; Move getSkin from User to RequestContext, do it without...dantman12:46, 3 April 2011

Status & tagging log