r85255 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85254‎ | r85255 | r85256 >
Date:13:42, 3 April 2011
Author:dantman
Status:ok
Tags:
Comment:
Fix a bug in LQT related to the RequestContext improvements. Skin and OutputPage both get their titles from RequestContext now so the bug for that workaround shouldn't exist anymore.
Modified paths:
  • /trunk/extensions/LiquidThreads/pages/TalkpageView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/pages/TalkpageView.php
@@ -343,7 +343,11 @@
344344
345345 // Workaround for bug 25077
346346 global $wgOut, $wgUser;
347 - $wgUser->getSkin()->setTitle( $wgOut->getTitle() );
 347+ $sk = $wgUser->getSkin();
 348+ if ( method_exists( $sk, 'setTitle' ) ) {
 349+ # Skin::setTitle was removed in 1.18, it already shares the same source of title with $wgOut.
 350+ $sk->setTitle( $wgOut->getTitle() );
 351+ }
348352
349353 return false;
350354 }

Status & tagging log