r85252 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85251‎ | r85252 | r85253 >
Date:12:55, 3 April 2011
Author:dantman
Status:ok
Tags:
Comment:
Followup r85250; Revert a static method back to use of $wgRequest... :/ damnit resourceloader...
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -3098,7 +3098,7 @@
30993099 * @return String: modified value of the "media" attribute
31003100 */
31013101 public static function transformCssMedia( $media ) {
3102 - global $wgHandheldForIPhone;
 3102+ global $wgRequest, $wgHandheldForIPhone;
31033103
31043104 // Switch in on-screen display for media testing
31053105 $switches = array(
@@ -3106,7 +3106,7 @@
31073107 'handheld' => 'handheld',
31083108 );
31093109 foreach( $switches as $switch => $targetMedia ) {
3110 - if( $this->getRequest()->getBool( $switch ) ) {
 3110+ if( $wgRequest->getBool( $switch ) ) {
31113111 if( $media == $targetMedia ) {
31123112 $media = '';
31133113 } elseif( $media == 'screen' ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r85392Fix for catchable fatals thrown on invalid titles, follow-up to miscellaneous...happy-melon23:09, 4 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85250Continue with r85240; Move getSkin from User to RequestContext, do it without...dantman12:46, 3 April 2011

Status & tagging log