r85243 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85242‎ | r85243 | r85244 >
Date:11:33, 3 April 2011
Author:dantman
Status:ok
Tags:
Comment:
Followup r85229; Drop this unnecessary reference on the user from ChangesList::newFromUser.
Modified paths:
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/includes/ChangesList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/hooks.txt
@@ -803,7 +803,7 @@
804804
805805 'FetchChangesList': When fetching the ChangesList derivative for
806806 a particular user
807 -&$user: User the list is being fetched for
 807+$user: User the list is being fetched for
808808 &$skin: Skin object to be used with the list
809809 &$list: List object (defaults to NULL, change it to an object
810810 instance and return false override the list derivative used)
Index: trunk/phase3/includes/ChangesList.php
@@ -47,12 +47,12 @@
4848 * @param $user User to fetch the list class for
4949 * @return ChangesList derivative
5050 */
51 - public static function newFromUser( &$user ) {
 51+ public static function newFromUser( $user ) {
5252 global $wgRequest;
5353
5454 $sk = $user->getSkin();
5555 $list = null;
56 - if( wfRunHooks( 'FetchChangesList', array( &$user, &$sk, &$list ) ) ) {
 56+ if( wfRunHooks( 'FetchChangesList', array( $user, &$sk, &$list ) ) ) {
5757 $new = $wgRequest->getBool( 'enhanced', $user->getOption( 'usenewrc' ) );
5858 return $new ? new EnhancedChangesList( $sk ) : new OldChangesList( $sk );
5959 } else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85229Followup r85227. Convert all IncludableSpecialPages to use context properly (...dantman05:46, 3 April 2011

Status & tagging log