r85234 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85233‎ | r85234 | r85235 >
Date:08:33, 3 April 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
Follow-up r85226, r85227: add @since annotations
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)
  • /trunk/phase3/includes/SpecialPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -779,6 +779,7 @@
780780 * Set the User object to use
781781 *
782782 * @param $u User object
 783+ * @since 1.18
783784 */
784785 public function setUser( $u ) {
785786 $this->mUser = $u;
@@ -788,6 +789,7 @@
789790 * Get the User object used in this instance
790791 *
791792 * @return User
 793+ * @since 1.18
792794 */
793795 public function getUser() {
794796 if ( !isset($this->mUser) ) {
@@ -802,6 +804,7 @@
803805 * Get the Skin object used to render this instance
804806 *
805807 * @return Skin
 808+ * @since 1.18
806809 */
807810 public function getSkin() {
808811 // For now we'll just proxy to the user. In the future a saner location for
Index: trunk/phase3/includes/SpecialPage.php
@@ -1006,6 +1006,7 @@
10071007 * Get the WebRequest being used for this instance
10081008 *
10091009 * @return WebRequest
 1010+ * @since 1.18
10101011 */
10111012 public function getRequest() {
10121013 if ( !isset($this->mRequest) ) {
@@ -1020,6 +1021,7 @@
10211022 * Get the OutputPage being used for this instance
10221023 *
10231024 * @return OutputPage
 1025+ * @since 1.18
10241026 */
10251027 public function getOutput() {
10261028 if ( !isset($this->mOutput) ) {
@@ -1034,6 +1036,7 @@
10351037 * Shortcut to get the skin being used for this instance
10361038 *
10371039 * @return User
 1040+ * @since 1.18
10381041 */
10391042 public function getUser() {
10401043 return $this->getOutput()->getUser();
@@ -1043,6 +1046,7 @@
10441047 * Shortcut to get the skin being used for this instance
10451048 *
10461049 * @return Skin
 1050+ * @since 1.18
10471051 */
10481052 public function getSkin() {
10491053 return $this->getOutput()->getSkin();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85226Start better utalizing OutputPage as the focal point for things related to th...dantman03:59, 3 April 2011
r85227Start managing output and input context from special pages themselves instead...dantman04:36, 3 April 2011

Status & tagging log