r85225 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85224‎ | r85225 | r85226 >
Date:03:07, 3 April 2011
Author:aaron
Status:ok
Tags:
Comment:
Make use of clean NULL in fi_img_timestamp for non-existing files
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevision.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevision.php
@@ -288,9 +288,8 @@
289289 'fi_rev_id' => $this->getRevId(),
290290 'fi_name' => $dbkey,
291291 'fi_img_sha1' => strval( $timeSHA1['sha1'] ),
292 - // b/c: fi_img_timestamp DEFAULT either NULL (new) or '' (old)
293 - 'fi_img_timestamp' => $timeSHA1['time'] ?
294 - $dbw->timestamp( $timeSHA1['time'] ) : ''
 292+ 'fi_img_timestamp' => $timeSHA1['time'] ? // '0' => NULL
 293+ $dbw->timestamp( $timeSHA1['time'] ) : null
295294 );
296295 }
297296 # Our review entry

Status & tagging log