r85144 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85143‎ | r85144 | r85145 >
Date:19:04, 1 April 2011
Author:tparscal
Status:ok
Tags:
Comment:
Fixed impossible condition - addresses comments on r84637
Modified paths:
  • /trunk/extensions/ArticleFeedback/api/ApiQueryArticleFeedback.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/api/ApiQueryArticleFeedback.php
@@ -35,7 +35,7 @@
3636 $res = $this->select( __METHOD__ );
3737 $ratings = array( $params['pageid'] => array( 'pageid' => $params['pageid'] ) );
3838 foreach ( $res as $i => $row ) {
39 - if ( !isset( $ratings[$params['pageid']] ) ) {
 39+ if ( !isset( $ratings[$params['pageid']]['revid'] ) ) {
4040 $ratings[$params['pageid']]['revid'] = $row->aap_revision;
4141 }
4242 if ( !isset( $ratings[$params['pageid']]['ratings'] ) ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84637Fixes more issues in r84535...tparscal21:52, 23 March 2011

Status & tagging log