r85104 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85103‎ | r85104 | r85105 >
Date:23:40, 31 March 2011
Author:brion
Status:ok
Tags:
Comment:
* (bug 27893) Edit-on-doubleclick now applies only on view and purge actions;
no longer triggers unexpectedly on delete, history etc.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -2347,7 +2347,7 @@
23482348
23492349 if (
23502350 $this->getTitle()->getNamespace() != NS_SPECIAL &&
2351 - !in_array( $action, array( 'edit', 'submit' ) ) &&
 2351+ in_array( $action, array( 'view', 'purge' ) ) &&
23522352 $wgUser->getOption( 'editondblclick' )
23532353 )
23542354 {
Index: trunk/phase3/RELEASE-NOTES
@@ -214,6 +214,8 @@
215215 * (bug 15641) Fixed positioning of permissions checks in Special:Import which
216216 allowed users without the 'import' permission to import pages if they directly
217217 submitted the form.
 218+* (bug 27893) Edit-on-doubleclick now applies only on view and purge actions;
 219+ no longer triggers unexpectedly on delete, history etc.
218220
219221 === API changes in 1.18 ===
220222 * (bug 26339) Throw warning when truncating an overlarge API result

Status & tagging log