r85053 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85052‎ | r85053 | r85054 >
Date:23:18, 30 March 2011
Author:laner
Status:deferred
Tags:
Comment:
New version of the packaging, fixing the init script
Modified paths:
  • /trunk/udpprofile/debian/changelog (modified) (history)
  • /trunk/udpprofile/debian/udpprofile.init (modified) (history)

Diff [purge]

Index: trunk/udpprofile/debian/changelog
@@ -1,3 +1,15 @@
 2+udpprofile (1.0-2) lucid-wikimedia; urgency=low
 3+
 4+ * Fix init script agin
 5+
 6+ -- Ryan Lane <rlane@wikimedia.org> Wed, 30 Mar 2011 23:07:00 +0000
 7+
 8+udpprofile (1.0-1) lucid-wikimedia; urgency=low
 9+
 10+ * Fix init script
 11+
 12+ -- Ryan Lane <rlane@wikimedia.org> Wed, 30 Mar 2011 22:59:28 +0000
 13+
214 udpprofile (1.0) lucid-wikimedia; urgency=low
315
416 * Initial package
Index: trunk/udpprofile/debian/udpprofile.init
@@ -20,7 +20,7 @@
2121 SCRIPTNAME=/etc/init.d/udpprofile
2222
2323 # Exit if the package is not installed
24 -[ -x "$START" ] || exit 0
 24+[ -x "$DAEMON" ] || exit 0
2525
2626 # Read configuration variable file if it is present
2727 [ -r /etc/default/$NAME ] && . /etc/default/$NAME
@@ -41,9 +41,9 @@
4242 # 0 if daemon has been started
4343 # 1 if daemon was already running
4444 # 2 if daemon could not be started
45 - start-stop-daemon --start --quiet -m -d /tmp -c $USER --exec $START --test > /dev/null \
 45+ start-stop-daemon --start --quiet -m --pidfile /var/lock/collector -d /tmp -c $USER --exec $DAEMON --test > /dev/null \
4646 || return 1
47 - start-stop-daemon --start --quiet -m -d /tmp -c $USER --exec $START \
 47+ start-stop-daemon --start --quiet -m --pidfile /var/lock/collector -d /tmp -c $USER --exec $DAEMON \
4848 || return 2
4949 # Add code here, if necessary, that waits for the process to be ready
5050 # to handle requests from services started subsequently which depend
@@ -60,7 +60,7 @@
6161 # 1 if daemon was already stopped
6262 # 2 if daemon could not be stopped
6363 # other if a failure occurred
64 - start-stop-daemon --start --quiet -c $USER --exec $STOP
 64+ start-stop-daemon --stop --quiet -c $USER --exec $DAEMON
6565 RETVAL="$?"
6666 [ "$RETVAL" = 2 ] && return 2
6767 return "$RETVAL"

Status & tagging log