r85042 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85041‎ | r85042 | r85043 >
Date:20:05, 30 March 2011
Author:happy-melon
Status:ok
Tags:
Comment:
Follow-up r85025 - use strict comparison
Modified paths:
  • /trunk/phase3/includes/specials/SpecialBlock.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialBlock.php
@@ -490,7 +490,7 @@
491491 # Give admins a heads-up before they go and block themselves. Much messier
492492 # to do this for IPs, but it's pretty unlikely they'd ever get the 'block'
493493 # permission anyway, although the code does allow for it
494 - if( $target == $wgUser->getName()
 494+ if( $target === $wgUser->getName()
495495 && $data['AlreadyBlocked'] != htmlspecialchars( $wgUser->getName() ) )
496496 {
497497 return array( 'ipb-blockingself' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85025(bug 23408) give admins a warning before letting them block themselves. Also...happy-melon18:00, 30 March 2011

Status & tagging log