r85040 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85039‎ | r85040 | r85041 >
Date:19:44, 30 March 2011
Author:reedy
Status:ok
Tags:
Comment:
Fixup a couple more undefined variables
Modified paths:
  • /trunk/phase3/maintenance/minify.php (modified) (history)
  • /trunk/phase3/maintenance/renamewiki.php (modified) (history)
  • /trunk/phase3/maintenance/storage/recompressTracked.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/renamewiki.php
@@ -57,7 +57,7 @@
5858 }
5959
6060 if ( count( $stores ) ) {
61 - $this->output( "Initialising external storage $store...\n" );
 61+ $this->output( "Initialising external storage...\n" );
6262 global $wgDBuser, $wgDBpassword, $wgExternalServers;
6363 foreach ( $stores as $storeURL ) {
6464 $m = array();
Index: trunk/phase3/maintenance/storage/recompressTracked.php
@@ -632,7 +632,7 @@
633633 foreach ( $res as $row ) {
634634 $text = Revision::getRevisionText( $row );
635635 if ( $text === false ) {
636 - $this->critical( "Error: cannot load revision text for old_id=$textId" );
 636+ $this->critical( "Error: cannot load revision text for old_id={$row->old_id}" );
637637 continue;
638638 }
639639
Index: trunk/phase3/maintenance/minify.php
@@ -95,7 +95,7 @@
9696 public function getExtension( $fileName ) {
9797 $dotPos = strrpos( $fileName, '.' );
9898 if ( $dotPos === false ) {
99 - $this->error( "No file extension, cannot determine type: $arg" );
 99+ $this->error( "No file extension, cannot determine type: $fileName" );
100100 exit( 1 );
101101 }
102102 return substr( $fileName, $dotPos + 1 );

Status & tagging log