r85026 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85025‎ | r85026 | r85027 >
Date:18:06, 30 March 2011
Author:happy-melon
Status:ok
Tags:
Comment:
Follow-up r85020 per CR - use strict comparison
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -1356,7 +1356,9 @@
13571357
13581358 // It is better to not parse the comment at all than to have templates expanded in the middle
13591359 // TODO: can the checkLabel be moved outside of the div so that wrapWikiMsg could be used?
1360 - $key = $comment ? 'confirmrecreate' : 'confirmrecreate-noreason';
 1360+ $key = $comment === ''
 1361+ ? 'confirmrecreate-noreason'
 1362+ : 'confirmrecreate';
13611363 $wgOut->addHTML(
13621364 '<div class="mw-confirm-recreate">' .
13631365 wfMsgExt( $key, 'parseinline', $username, "<nowiki>$comment</nowiki>" ) .

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85020(bug 18937) avoid broken wikimarkup (four apostrophes together) in MediaWiki:...happy-melon17:04, 30 March 2011

Status & tagging log