r84968 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84967‎ | r84968 | r84969 >
Date:16:53, 29 March 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
param name change
Modified paths:
  • /trunk/extensions/SemanticResultFormats/GraphViz/SRF_Graph.php (modified) (history)
  • /trunk/extensions/SemanticResultFormats/SRF_Messages.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticResultFormats/GraphViz/SRF_Graph.php
@@ -79,6 +79,10 @@
8080 $this->m_graphLegend = array_key_exists( 'graphlegend', $params ) && strtolower( trim( $params['graphlegend'] ) ) == 'yes';
8181 $this->m_graphLabel = array_key_exists( 'graphlabel', $params ) && strtolower( trim( $params['graphlabel'] ) ) == 'yes';
8282
 83+ if ( array_key_exists( 'arrowdirection', $params ) ) {
 84+ $params['rankdir'] = $params['arrowdirection'];
 85+ }
 86+
8387 if ( array_key_exists( 'rankdir', $params ) ) {
8488 $this->m_rankdir = strtoupper( trim( $params['rankdir'] ) );
8589 }
@@ -288,7 +292,7 @@
289293 array( 'name' => 'graphsize', 'type' => 'int', 'description' => wfMsg( 'srf_paramdesc_graphsize' ) ),
290294 array( 'name' => 'graphlegend', 'type' => 'enumeration', 'description' => wfMsg( 'srf_paramdesc_graphlegend' ), 'values'=> array( 'yes', 'no' ) ),
291295 array( 'name' => 'graphlabel', 'type' => 'enumeration', 'description' => wfMsg( 'srf_paramdesc_graphlabel' ), 'values'=> array( 'yes', 'no' ) ),
292 - array( 'name' => 'rankdir', 'type' => 'string', 'description' => wfMsg( 'srf_paramdesc_rankdir' ) ),
 296+ array( 'name' => 'arrowdirection', 'type' => 'string', 'description' => wfMsg( 'srf_paramdesc_rankdir' ) ),
293297 array( 'name' => 'graphlink', 'type' => 'enumeration', 'description' => wfMsg( 'srf_paramdesc_graphlink' ), 'values'=> array( 'yes', 'no' ) ),
294298 array( 'name' => 'graphcolor', 'type' => 'enumeration', 'description' => wfMsg( 'srf_paramdesc_graphcolor' ), 'values'=> array( 'yes', 'no' ) ),
295299 array( 'name' => 'nodeshape', 'type' => 'enumeration', 'description' => wfMsg( 'srf-paramdesc-graph-nodeshape' ), 'values'=> self::$NODE_SHAPES ),
Index: trunk/extensions/SemanticResultFormats/SRF_Messages.php
@@ -108,7 +108,7 @@
109109 'srf_paramdesc_graphsize' => 'Graph size (in px)',
110110 'srf_paramdesc_graphlegend' => 'Show graph legend or not',
111111 'srf_paramdesc_graphlabel' => 'Graph label',
112 - 'srf_paramdesc_rankdir' => 'Graph build direction',
 112+ 'srf_paramdesc_rankdir' => 'Arrow direction',
113113 'srf_paramdesc_graphlink' => 'Graph link',
114114 'srf_paramdesc_graphcolor' => 'Graph color',
115115 'srf-paramdesc-graph-wwl' => 'Word wrap limit (in # characters)',

Status & tagging log