r84945 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84944‎ | r84945 | r84946 >
Date:02:07, 29 March 2011
Author:dale
Status:deferred
Tags:
Comment:
removed appendJS function ( mwEmbedSupport does not support gadgets atm )
Modified paths:
  • /trunk/extensions/MwEmbedSupport/MwEmbedModules/MediaWikiSupport/resources/MediaWikiPlayerSupport.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MwEmbedSupport/MwEmbedModules/MediaWikiSupport/resources/MediaWikiPlayerSupport.js
@@ -252,14 +252,12 @@
253253 var provider = $( embedPlayer).attr( 'data-mwprovider');
254254
255255 var iframeUrl = false;
256 - var appendJs = ( mw.getConfig( 'Mw.AppendWithJS' ) )? mw.getConfig( 'Mw.AppendWithJS' ) + '&' : '';
257256 if( mw.getConfig('wgServer') && mw.getConfig('wgArticlePath') ){
258257 iframeUrl = mw.getConfig('wgServer') +
259258 mw.getConfig('wgArticlePath').replace( /\$1/, 'File:' +
260259 unescape( embedPlayer.apiTitleKey ).replace( /^(File:|Image:)/ , '' ) ) +
261 - '?' + appendJs + 'embedplayer=yes';
 260+ '?' + 'embedplayer=yes';
262261 }
263 -
264262 callback( iframeUrl );
265263 });
266264 };

Status & tagging log