r84940 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84939‎ | r84940 | r84941 >
Date:23:47, 28 March 2011
Author:dale
Status:deferred
Tags:
Comment:
added /* @embed */ to loader gif
Modified paths:
  • /trunk/extensions/MwEmbedSupport/MwEmbedModules/MwEmbedSupport/jquery/jquery.triggerQueueCallback.js (modified) (history)
  • /trunk/extensions/MwEmbedSupport/MwEmbedModules/MwEmbedSupport/skins/common/MwEmbedCommonStyle.css (modified) (history)
  • /trunk/extensions/MwEmbedSupport/MwEmbedSupport.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MwEmbedSupport/MwEmbedSupport.php
@@ -49,7 +49,7 @@
5050 MwEmbedResourceManager::register( 'extensions/MwEmbedSupport/MwEmbedModules/MediaWikiSupport' );
5151
5252 // Add MwEmbedSupport to Startup:
53 -function MwUpdateStartupModules( &$modules ){
 53+function MwUpdateStartupModules( &$modules ){
5454 // TODO parser will become part of core once Neil's parser patch gets in there.
5555 array_push($modules, 'mediawiki.language', 'mediawiki.language.parser', 'jquery.triggerQueueCallback',
5656 'jquery.mwEmbedUtil', 'mwEmbedStartup' );
Index: trunk/extensions/MwEmbedSupport/MwEmbedModules/MwEmbedSupport/jquery/jquery.triggerQueueCallback.js
@@ -54,7 +54,7 @@
5555 }
5656
5757 if( !callbackSet || callbackSet.length === 0 ){
58 - mw.log( '"mwEmbed::jQuery.triggerQueueCallback: No events run the callback directly: ' + triggerName );
 58+ //mw.log( '"mwEmbed::jQuery.triggerQueueCallback: No events run the callback directly: ' + triggerName );
5959 // No events run the callback directly
6060 callback();
6161 return ;
Index: trunk/extensions/MwEmbedSupport/MwEmbedModules/MwEmbedSupport/skins/common/MwEmbedCommonStyle.css
@@ -19,7 +19,8 @@
2020 height:32px;
2121 display:block;
2222 padding:0px;
23 - background-image: url('images/loading_ani.gif');
 23+ /* @embed */
 24+ background-image: url(images/loading_ani.gif);
2425 margin: auto;
2526 }
2627 .cssLoadingSpinner {

Status & tagging log