r84923 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84922‎ | r84923 | r84924 >
Date:21:22, 28 March 2011
Author:diederik
Status:deferred
Tags:
Comment:
Added support for a default chart.
Modified paths:
  • /trunk/tools/editor_trends/classes/runtime_settings.py (modified) (history)

Diff [purge]

Index: trunk/tools/editor_trends/classes/runtime_settings.py
@@ -123,9 +123,7 @@
124124
125125 def determine_chart(self, chart):
126126 requested_charts = []
127 - if getattr(chart, 'func_name') == True:
128 - requested_charts.append(chart.func_name)
129 - elif chart != None and getattr(chart, 'func_name') == False:
 127+ if chart != None and getattr(chart, 'func_name', None) == None:
130128 charts = chart.split(',')
131129 available_charts = inventory.available_analyses()
132130 for chart in charts:
@@ -134,7 +132,8 @@
135133 sys.exit(-1)
136134 else:
137135 requested_charts.append(chart)
138 - print requsted_charts
 136+ elif getattr(chart, 'func_name', None) != None:
 137+ requested_charts.append(chart.func_name)
139138 return requested_charts
140139
141140 def get_project_location(self):