r84898 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84897‎ | r84898 | r84899 >
Date:05:44, 28 March 2011
Author:tstarling
Status:ok
Tags:
Comment:
CURLOPT_CONNECTTIMEOUT_MS also not available
Modified paths:
  • /branches/wmf/1.17wmf1/includes/objectcache/EhcacheBagOStuff.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/includes/objectcache/EhcacheBagOStuff.php
@@ -23,7 +23,6 @@
2424 ? $params['connectTimeout'] : 1;
2525 $this->timeout = isset( $params['timeout'] ) ? $params['timeout'] : 1;
2626 $this->curlOptions = array(
27 - CURLOPT_CONNECTTIMEOUT_MS => intval( $this->connectTimeout * 1000 ),
2827 CURLOPT_RETURNTRANSFER => 1,
2928 CURLOPT_CUSTOMREQUEST => 'GET',
3029 CURLOPT_POST => 0,
@@ -32,8 +31,10 @@
3332 );
3433 if ( defined( 'CURLOPT_TIMEOUT_MS' ) ) {
3534 $this->curlOptions[CURLOPT_TIMEOUT_MS] = intval( $this->timeout * 1000 );
 35+ $this->curlOptions[CURLOPT_CONNECTTIMEOUT_MS] = intval( $this->connectTimeout * 1000 );
3636 } else {
3737 $this->curlOptions[CURLOPT_TIMEOUT] = ceil( $this->timeout );
 38+ $this->curlOptions[CURLOPT_CONNECTTIMEOUT] = ceil( $this->connectTimeout );
3839 }
3940 }
4041

Status & tagging log