r84868 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84867‎ | r84868 | r84869 >
Date:18:17, 27 March 2011
Author:reedy
Status:reverted
Tags:
Comment:
Use $updater->addNewExtension
Modified paths:
  • /trunk/extensions/ConfirmAccount/ConfirmAccount.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmAccount/ConfirmAccount.php
@@ -274,7 +274,7 @@
275275 }
276276 } else {
277277 if ( $updater->getDB()->getType() == 'mysql' ) {
278 - $updater->addExtensionUpdate( array( 'addTable', 'account_requests', "$base/ConfirmAccount.sql", true ) );
 278+ $updater->addNewExtension( 'ConfirmAccount', "$base/ConfirmAccount.sql" );
279279
280280 $updater->addExtensionUpdate( array( 'addField', 'account_requests', 'acr_filename',
281281 "$base/archives/patch-acr_filename.sql", true ) );
@@ -285,7 +285,7 @@
286286
287287 $updater->addExtensionUpdate( array( 'addIndex', 'account_requests', 'acr_email', "$base/archives/patch-email-index.sql", true ) );
288288 } else if ( $updater->getDB()->getType() == 'postgres' ) {
289 - $updater->addExtensionUpdate( array( 'addTable', 'account_requests', "$base/ConfirmAccount.pg.sql", true ) );
 289+ $updater->addNewExtension( 'ConfirmAccount', "$base/ConfirmAccount.pg.sql" );
290290
291291 $updater->addExtensionUpdate( array( 'addPgField', 'account_requests', 'acr_held', "TIMESTAMPTZ" ) );
292292 $updater->addExtensionUpdate( array( 'addPgField', 'account_requests', 'acr_filename', "TEXT" ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r89660Get rid of addNewExtension()/getNewExtensions() method of adding new extensio...demon17:33, 7 June 2011

Status & tagging log