r84866 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84865‎ | r84866 | r84867 >
Date:17:55, 27 March 2011
Author:maxsem
Status:ok
Tags:
Comment:
Follow-up r84864: total war on TYPE=<...> instead of ENGINE=<...> in extensions. Use $wgDBTableOptions where appropriate.
Modified paths:
  • /trunk/extensions/Aggregator/aggregator.sql (modified) (history)
  • /trunk/extensions/AjaxShowEditors/patch-editings.sql (modified) (history)
  • /trunk/extensions/ConfirmAccount/archives/patch-account_credentials.sql (modified) (history)
  • /trunk/extensions/OAI/update_table.sql (modified) (history)
  • /trunk/extensions/Patroller/patroller.sql (modified) (history)
  • /trunk/extensions/PovWatch/povwatch.sql (modified) (history)
  • /trunk/extensions/SisterSites/SisterSites.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/SisterSites/SisterSites.sql
@@ -14,7 +14,7 @@
1515 sss_listurl TEXT,
1616
1717 PRIMARY KEY (sss_id)
18 -) TYPE=InnoDB;
 18+) /*$wgDBTableOptions*/;
1919
2020 CREATE TABLE /*$wgDBprefix*/sistersites_page (
2121 ssp_id INT AUTO_INCREMENT,
@@ -42,4 +42,4 @@
4343
4444 -- Index for updating sites
4545 KEY (ssp_site, ssp_url)
46 -) TYPE=InnoDB;
 46+) /*$wgDBTableOptions*/;
Index: trunk/extensions/OAI/update_table.sql
@@ -17,7 +17,7 @@
1818 -- We routinely pull things based on timestamp.
1919 KEY up_timestamp(up_timestamp),
2020 KEY up_sequence(up_sequence,up_timestamp)
21 -) TYPE=InnoDB;
 21+) /*$wgDBTableOptions*/;
2222
2323 --
2424 -- Initialize the table from the current state.
Index: trunk/extensions/Aggregator/aggregator.sql
@@ -1,4 +1,4 @@
2 -CREATE TABLE feeditem(
 2+CREATE TABLE /*_*/feeditem(
33 fi_feed VARCHAR(255),
44 fi_date CHAR(14),
55 fi_title TEXT,
@@ -7,11 +7,11 @@
88 fi_author TEXT,
99 fi_comments TEXT,
1010 KEY (fi_feed,fi_date)
11 -) TYPE=InnoDB;
 11+) /*$wgDBTableOptions*/;
1212
13 -CREATE TABLE feed (
 13+CREATE TABLE /*_*/feed (
1414 feed_group VARCHAR(128),
1515 feed_url VARCHAR(255),
1616 feed_touched CHAR(14),
1717 UNIQUE KEY (feed_group,feed_url)
18 -) TYPE=InnoDB;
 18+) /*$wgDBTableOptions*/;
Index: trunk/extensions/Patroller/patroller.sql
@@ -5,4 +5,4 @@
66 ptr_timestamp varchar(14) NOT NULL,
77 UNIQUE KEY ptr_change (ptr_change),
88 KEY ptr_timestamp (ptr_timestamp)
9 -) TYPE=MEMORY;
\ No newline at end of file
 9+) ENGINE=MEMORY;
\ No newline at end of file
Index: trunk/extensions/AjaxShowEditors/patch-editings.sql
@@ -6,4 +6,4 @@
77 PRIMARY KEY (`editings_page`,`editings_user`),
88 KEY `editings_page` (`editings_page`),
99 KEY `editings_page_started` (`editings_page`,`editings_user`,`editings_started`)
10 -) TYPE=MEMORY;
 10+) ENGINE=MEMORY;
Index: trunk/extensions/PovWatch/povwatch.sql
@@ -19,11 +19,11 @@
2020
2121 PRIMARY KEY (pwl_id),
2222 INDEX (pwl_timestamp)
23 -) TYPE=InnoDB;
 23+) /*$wgDBTableOptions*/;
2424
2525 -- List of subscribers
2626 CREATE TABLE /*$wgDBprefix*/povwatch_subscribers (
2727 -- Link to user_id
2828 pws_user INT NOT NULL,
2929 PRIMARY KEY (pws_user)
30 -) TYPE=InnoDB;
 30+) /*$wgDBTableOptions*/;
Index: trunk/extensions/ConfirmAccount/archives/patch-account_credentials.sql
@@ -48,4 +48,4 @@
4949 PRIMARY KEY (acd_user_id,acd_id),
5050 UNIQUE KEY (acd_id)
5151
52 -) TYPE=InnoDB;
 52+) /*$wgDBTableOptions*/;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84864/*$wgDBprefix*/ -> /*_*/...demon17:43, 27 March 2011

Status & tagging log