r8486 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r8485‎ | r8486 | r8487 >
Date:06:20, 21 April 2005
Author:vibber
Status:old
Tags:
Comment:
* (bug 1636) Refs like ţ were misinterpreted as octal in some places
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -213,7 +213,7 @@
214214 function wfMungeToUtf8( $string ) {
215215 global $wgInputEncoding; # This is debatable
216216 #$string = iconv($wgInputEncoding, "UTF-8", $string);
217 - $string = preg_replace ( '/&#([0-9]+);/e', 'wfUtf8Sequence($1)', $string );
 217+ $string = preg_replace ( '/&#0*([0-9]+);/e', 'wfUtf8Sequence($1)', $string );
218218 $string = preg_replace ( '/&#x([0-9a-f]+);/ie', 'wfUtf8Sequence(0x$1)', $string );
219219 # Should also do named entities here
220220 return $string;

Follow-up revisions

RevisionCommit summaryAuthorDate
r8487* (bug 1636) Refs like ţ were misinterpreted as octal in some places...vibber06:28, 21 April 2005
r8488* (bug 1636) Refs like ţ were misinterpreted as octal in some placesvibber06:29, 21 April 2005
r41507Reverting r41410 -- broke interwikis totally in parser tests....brion16:59, 1 October 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r8484Test case for bug 1636vibber06:04, 21 April 2005

Status & tagging log