r84815 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84814‎ | r84815 | r84816 >
Date:19:29, 26 March 2011
Author:ialex
Status:ok
Tags:
Comment:
Restore calls to SpecialPage::outputHeader(), no longer called since the rewrite to subclass SpecialPage
Modified paths:
  • /trunk/phase3/includes/specials/SpecialListfiles.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialNewimages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialListfiles.php
@@ -30,6 +30,7 @@
3131 public function execute( $par ){
3232 global $wgOut;
3333 $this->setHeaders();
 34+ $this->outputHeader();
3435
3536 $pager = new ImageListPager( $par );
3637
Index: trunk/phase3/includes/specials/SpecialNewimages.php
@@ -27,8 +27,10 @@
2828 }
2929
3030 public function execute( $par ){
31 - global $wgOut, $wgLang;
 31+ global $wgOut;
 32+
3233 $this->setHeaders();
 34+ $this->outputHeader();
3335
3436 $pager = new NewFilesPager( $par );
3537
@@ -160,4 +162,4 @@
161163
162164 return $form;
163165 }
164 -}
\ No newline at end of file
 166+}

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84814Topple the last bastion of global-function-based special pages. Also fix HTM...happy-melon19:18, 26 March 2011

Status & tagging log