r84742 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84741‎ | r84742 | r84743 >
Date:11:28, 25 March 2011
Author:reedy
Status:deferred
Tags:
Comment:
Fix undefined variables

Bryan: Is this extension still needed? A minimum, it's a class name duplicate of PngHandler in phase3
Modified paths:
  • /trunk/extensions/PNGHandler/PNGHandler_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/PNGHandler/PNGHandler_body.php
@@ -25,7 +25,7 @@
2626 return new ThumbnailImage( $image, $image->getURL(), $clientWidth, $clientHeight, $srcPath );
2727 }
2828
29 - wfDebug( __METHOD__.": creating {$physicalWidth}x{$physicalHeight} thumbnail at $dstPath\n" );
 29+ wfDebug( __METHOD__.": creating {$params['physicalWidth']}x{$params['physicalHeight']} thumbnail at $dstPath\n" );
3030
3131 $cmd = "{$egPngdsPath}pngds ".
3232 "--width {$params['physicalWidth']} ".

Status & tagging log