r84738 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84737‎ | r84738 | r84739 >
Date:10:56, 25 March 2011
Author:reedy
Status:ok
Tags:
Comment:
Add/tweak/update documentation and add some explicit defintions with type descriptions
Modified paths:
  • /trunk/phase3/includes/objectcache/MemcachedClient.php (modified) (history)
  • /trunk/phase3/includes/objectcache/MemcachedPhpBagOStuff.php (modified) (history)
  • /trunk/phase3/includes/objectcache/SqlBagOStuff.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/objectcache/MemcachedPhpBagOStuff.php
@@ -4,7 +4,13 @@
55 * A wrapper class for the pure-PHP memcached client, exposing a BagOStuff interface.
66 */
77 class MemcachedPhpBagOStuff extends BagOStuff {
 8+
89 /**
 10+ * @var MemCachedClientforWiki
 11+ */
 12+ protected $client;
 13+
 14+ /**
915 * Constructor.
1016 *
1117 * Available parameters are:
Index: trunk/phase3/includes/objectcache/SqlBagOStuff.php
@@ -6,7 +6,17 @@
77 * @ingroup Cache
88 */
99 class SqlBagOStuff extends BagOStuff {
10 - var $lb, $db, $serverInfo;
 10+
 11+ /**
 12+ * @var LoadBalancer
 13+ */
 14+ var $lb;
 15+
 16+ /**
 17+ * @var DatabaseBase
 18+ */
 19+ var $db;
 20+ var $serverInfo;
1121 var $lastExpireAll = 0;
1222
1323 /**
@@ -21,6 +31,9 @@
2232 }
2333 }
2434
 35+ /**
 36+ * @return DatabaseBase
 37+ */
2538 protected function getDB() {
2639 if ( !isset( $this->db ) ) {
2740 # If server connection info was given, use that
Index: trunk/phase3/includes/objectcache/MemcachedClient.php
@@ -554,7 +554,7 @@
555555 * with a \n. This is with the PHP flag auto_detect_line_endings set
556556 * to falase (the default).
557557 *
558 - * @param $sock Ressource: socket to send command on
 558+ * @param $sock Resource: socket to send command on
559559 * @param $cmd String: command to run
560560 *
561561 * @return Array: output array
@@ -857,7 +857,7 @@
858858 /**
859859 * Load items into $ret from $sock
860860 *
861 - * @param $sock Ressource: socket to read from
 861+ * @param $sock Resource: socket to read from
862862 * @param $ret Array: returned values
863863 *
864864 * @access private

Status & tagging log