r84716 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84715‎ | r84716 | r84717 >
Date:22:00, 24 March 2011
Author:reedy
Status:deferred
Tags:
Comment:
Partial revert to r84652

Also, removed some more old useless includes where I'd removed global $IP; before
Modified paths:
  • /trunk/extensions/FirefoggChunkedUpload/tests/UploadFromChunksTest.php (modified) (history)
  • /trunk/extensions/OAI/OAIRepo_body.php (modified) (history)
  • /trunk/extensions/RDFIO/stores/SMW_ARC2Store.php (modified) (history)
  • /trunk/extensions/SemanticNotifyMe/includes/jobs/SMW_NMRefreshJob.php (modified) (history)
  • /trunk/extensions/SemanticNotifyMe/specials/SMWNotifyMe/SMWNotifyMe.php (modified) (history)
  • /trunk/extensions/SocialProfile/SystemGifts/SystemGifts.php (modified) (history)
  • /trunk/extensions/skins/Daddio/Daddio.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SocialProfile/SystemGifts/SystemGifts.php
@@ -1,5 +1,8 @@
22 <?php
33
 4+global $IP, $wgScriptPath, $wgAutoloadClasses, $wgAvailableRights, $wgGroupPermissions,
 5+ $wgSpecialPages, $wgExtenstionMessagesFiles;
 6+
47 $wgAvailableRights[] = 'awardsmanage';
58 $wgGroupPermissions['staff']['awardsmanage'] = true;
69 $wgGroupPermissions['sysop']['awardsmanage'] = true;
Index: trunk/extensions/OAI/OAIRepo_body.php
@@ -3,8 +3,8 @@
44 die();
55 }
66
 7+global $IP;
78 require_once( "$IP/extensions/OAI/OAIFunctions.php" );
8 -require_once( "$IP/includes/Export.php" );
99
1010 if( !function_exists( 'wfTimestamp2ISO8601' ) ) {
1111 // Back compat; gone in 1.6
Index: trunk/extensions/FirefoggChunkedUpload/tests/UploadFromChunksTest.php
@@ -1,5 +1,6 @@
22 <?php
33
 4+global $IP;
45 require_once( "$IP/maintenance/tests/ApiSetup.php" );
56 require_once( "$IP/maintenance/deleteArchivedFiles.inc" );
67 require_once( "$IP/maintenance/deleteArchivedRevisions.inc" );
Index: trunk/extensions/SemanticNotifyMe/specials/SMWNotifyMe/SMWNotifyMe.php
@@ -5,8 +5,6 @@
66
77 if ( !defined( 'MEDIAWIKI' ) ) die();
88
9 -require_once( $IP . "/includes/SpecialPage.php" );
10 -
119 /*
1210 * Standard class that is resopnsible for the creation of the Special Page
1311 */
Index: trunk/extensions/SemanticNotifyMe/includes/jobs/SMW_NMRefreshJob.php
@@ -7,8 +7,6 @@
88 die( "This file is part of the Semantic NotifyMe Extension. It is not a valid entry point.\n" );
99 }
1010
11 -require_once( "$IP/includes/JobQueue.php" );
12 -
1311 class SMWNMRefreshJob extends Job {
1412
1513 function __construct( Title $title ) {
Index: trunk/extensions/RDFIO/stores/SMW_ARC2Store.php
@@ -4,6 +4,8 @@
55 die( 'Not a valid entry point.' );
66 }
77
 8+global $IP;
 9+
810 require_once( "$IP/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2.php" );
911
1012 /**
Index: trunk/extensions/skins/Daddio/Daddio.class.php
@@ -8,6 +8,7 @@
99 if( !defined( 'MEDIAWIKI' ) )
1010 die( -1 );
1111
 12+global $IP;
1213 // @todo Fixme: autoload ModernTemplate
1314 require_once( "$IP/skins/Modern.php" );
1415

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84652using "global $IP" in the global scope isn't going to do anything...reedy00:41, 24 March 2011

Status & tagging log