r84609 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84608‎ | r84609 | r84610 >
Date:17:29, 23 March 2011
Author:maxsem
Status:ok
Tags:
Comment:
Tweaks for r84594:
* Made Tipsy a dependency instead of making another request to load it programmatically
* Made it available everywhere in Special:Code, not just in revision lists. Ideally, it should be available on every pageview to improve links to revisions from ordinary wiki pages.
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.php (modified) (history)
  • /trunk/extensions/CodeReview/modules/ext.codereview.tooltips.js (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/SpecialCode.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReview.php
@@ -151,7 +151,8 @@
152152
153153 // Revision tooltips CodeRevisionView:
154154 $wgResourceModules['ext.codereview.tooltips'] = array(
155 - 'scripts' => 'ext.codereview.tooltips.js'
 155+ 'scripts' => 'ext.codereview.tooltips.js',
 156+ 'dependencies' => 'jquery.tipsy'
156157 ) + $commonModuleInfo;
157158
158159 // If you are running a closed svn, fill the following two lines with the username and password
Index: trunk/extensions/CodeReview/modules/ext.codereview.tooltips.js
@@ -48,6 +48,4 @@
4949 });
5050 };
5151
52 -mw.loader.using( 'jquery.tipsy', function(){
53 - $( document ).ready( CodeTooltipsInit );
54 -});
 52+$( document ).ready( CodeTooltipsInit );
Index: trunk/extensions/CodeReview/ui/SpecialCode.php
@@ -19,6 +19,7 @@
2020 $this->setHeaders();
2121 // Base styles used for all code review UI actions.
2222 $wgOut->addModules( 'ext.codereview' );
 23+ $wgOut->addModules( 'ext.codereview.tooltips' );
2324
2425 $view = $this->getViewFrom( $subpage );
2526 if( $view ) {
Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
@@ -78,8 +78,6 @@
7979
8080 $navBar = $pager->getNavigationBar();
8181
82 - $wgOut->addModules( 'ext.codereview.tooltips' );
83 -
8482 $wgOut->addHTML( $pathForm );
8583
8684 $wgOut->addHTML(

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84594Per mailing list, import MaxSems tooltip gadget from http://www.mediawiki.org......reedy14:24, 23 March 2011

Status & tagging log