r84604 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84603‎ | r84604 | r84605 >
Date:16:45, 23 March 2011
Author:catrope
Status:ok
Tags:
Comment:
1.17wmf1: MFT r83494, r84454, r84464, r84543, r84574. Did not merge the i18n part of r83494 (removing a message) because it caused conflicts
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/Renameuser/Renameuser.php (modified) (history)
  • /branches/wmf/1.17wmf1/extensions/Renameuser/Renameuser_body.php (modified) (history)
  • /branches/wmf/1.17wmf1/includes/ChangeTags.php (modified) (history)
  • /branches/wmf/1.17wmf1/languages/Names.php (modified) (history)
  • /branches/wmf/1.17wmf1/languages/messages/MessagesLtg.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/Renameuser/Renameuser_body.php
@@ -63,8 +63,7 @@
6464 wfRunHooks( 'RenameUserWarning', array( $oun, $nun, &$warnings ) );
6565 }
6666
67 - $wgOut->addHTML( "
68 - <!-- Current contributions limit is " . RENAMEUSER_CONTRIBLIMIT . " -->" .
 67+ $wgOut->addHTML(
6968 Xml::openElement( 'form', array( 'method' => 'post', 'action' => $this->getTitle()->getLocalUrl(), 'id' => 'renameuser' ) ) .
7069 Xml::openElement( 'fieldset' ) .
7170 Xml::element( 'legend', null, wfMsg( 'renameuser' ) ) .
@@ -251,20 +250,6 @@
252251 // Always get the edits count, it will be used for the log message
253252 $contribs = User::edits( $uid );
254253
255 - // Check edit count
256 - if ( !$wgUser->isAllowed( 'siteadmin' ) ) {
257 - if ( RENAMEUSER_CONTRIBLIMIT != 0 && $contribs > RENAMEUSER_CONTRIBLIMIT ) {
258 - $wgOut->addWikiText( "<div class=\"errorbox\">" .
259 - wfMsg( 'renameusererrortoomany',
260 - $oldusername->getText(),
261 - $wgLang->formatNum( $contribs ),
262 - $wgLang->formatNum( RENAMEUSER_CONTRIBLIMIT )
263 - )
264 - . "</div>" );
265 - return;
266 - }
267 - }
268 -
269254 // Give other affected extensions a chance to validate or abort
270255 if ( !wfRunHooks( 'RenameUserAbort', array( $uid, $oldusername->getText(), $newusername->getText() ) ) ) {
271256 return;
Index: branches/wmf/1.17wmf1/extensions/Renameuser/Renameuser.php
@@ -28,10 +28,9 @@
2929 $wgExtensionAliasesFiles['Renameuser'] = $dir . 'Renameuser.alias.php';
3030
3131 /**
32 - * The maximum number of edits a user can have and still be allowed renaming,
33 - * set it to 0 to disable the limit.
 32+ * Users with more than this number of edits will have their rename operation
 33+ * deferred via the job queue.
3434 */
35 -define( 'RENAMEUSER_CONTRIBLIMIT', 25000 );
3635 define( 'RENAMEUSER_CONTRIBJOB', 5000 );
3736
3837 # Add a new log type
Index: branches/wmf/1.17wmf1/includes/ChangeTags.php
@@ -169,7 +169,7 @@
170170
171171 $html = implode( '&#160;', $data );
172172 $html .= "\n" . Xml::element( 'input', array( 'type' => 'submit', 'value' => wfMsg( 'tag-filter-submit' ) ) );
173 - $html .= "\n" . Html::hidden( 'title', $wgTitle-> getPrefixedText() );
 173+ $html .= "\n" . Html::hidden( 'title', $wgTitle->getPrefixedText() );
174174 $html = Xml::tags( 'form', array( 'action' => $wgTitle->getLocalURL(), 'method' => 'get' ), $html );
175175
176176 return $html;
Index: branches/wmf/1.17wmf1/languages/messages/MessagesLtg.php
@@ -10,6 +10,25 @@
1111 * @author Dark Eagle
1212 * @author Jureits
1313 */
 14+
 15+$namespaceNames = array(
 16+ NS_MEDIA => 'Medeja',
 17+ NS_SPECIAL => 'Seviškuo',
 18+ NS_TALK => 'Sprīža',
 19+ NS_USER => 'Lītuotuojs',
 20+ NS_USER_TALK => 'Sprīža_ap_lītuotuoju',
 21+ NS_PROJECT_TALK => 'Sprīža_ap_{{GRAMMAR:accusative|$1}}',
 22+ NS_FILE => 'Fails',
 23+ NS_FILE_TALK => 'Sprīža_ap_failu',
 24+ NS_MEDIAWIKI => 'MediaWiki',
 25+ NS_MEDIAWIKI_TALK => 'Sprīža_ap_MediaWiki',
 26+ NS_TEMPLATE => 'Taiss',
 27+ NS_TEMPLATE_TALK => 'Sprīža_ap_taisu',
 28+ NS_HELP => 'Paleigs',
 29+ NS_HELP_TALK => 'Sprīža_ap_paleigu',
 30+ NS_CATEGORY => 'Kategoreja',
 31+ NS_CATEGORY_TALK => 'Sprīža_ap_kategoreju',
 32+);
1433
1534 $fallback = 'lv';
1635
Index: branches/wmf/1.17wmf1/languages/Names.php
@@ -150,7 +150,7 @@
151151 'ka' => 'ქართული', # Georgian
152152 'kaa' => 'Qaraqalpaqsha', # Karakalpak
153153 'kab' => 'Taqbaylit', # Kabyle
154 - 'kbd' => 'къэбэрдеибзэ/qabardjajəbza', # Kabardian (multiple scripts - defaults to Cyrillic)
 154+ 'kbd' => 'Къэбэрдеибзэ / Qabardjajəbza', # Kabardian (multiple scripts - defaults to Cyrillic)
155155 'kbd-cyrl' => 'къэбэрдеибзэ', # Kabardian (Cyrillic)
156156 'kg' => 'Kongo', # Kongo, (FIXME!) should probaly be KiKongo or KiKoongo
157157 'ki' => 'Gĩkũyũ', # Gikuyu
Property changes on: branches/wmf/1.17wmf1/languages/Names.php
___________________________________________________________________
Modified: svn:mergeinfo
158158 Merged /trunk/phase3/languages/Names.php:r84464,84543,84574

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83494Remove the limit on edit count, it is unnecessary now that we have job queue ...tstarling01:12, 8 March 2011
r84454Fixed occasional fatal in getRedirectHtml(), not sure when this cropped upaaron15:54, 21 March 2011
r84464Bug 28159 - Change interwiki name of language kbd to Къэбэрдеибзэ...raymond17:23, 21 March 2011
r84543Bug 28184 - Namespaces for the Latgalian Wikipedia...raymond19:02, 22 March 2011
r84574Remove sneaky space in class-> method() call...hashar22:26, 22 March 2011

Status & tagging log