r84595 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84594‎ | r84595 | r84596 >
Date:14:50, 23 March 2011
Author:demon
Status:ok
Tags:
Comment:
Followup r83485: don't hardcode the mem limit in two places, just reuse the const
Modified paths:
  • /trunk/extensions/CodeReview/backend/Subversion.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/Subversion.php
@@ -127,8 +127,8 @@
128128 function __construct( $repo ) {
129129 parent::__construct( $repo );
130130 global $wgMaxShellMemory;
131 - if( $wgMaxShellMemory < SubversionShell::MIN_MEMORY ) {
132 - $wgMaxShellMemory = 204800;
 131+ if( $wgMaxShellMemory < self::MIN_MEMORY ) {
 132+ $wgMaxShellMemory = self::MIN_MEMORY;
133133 wfDebug( __METHOD__ . " raised wgMaxShellMemory to $wgMaxShellMemory\n" );
134134 }
135135 }

Sign-offs

UserFlagDate
Hasharinspected18:53, 23 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83485raises shell adaptor virtual memory limitation...hashar20:45, 7 March 2011

Status & tagging log