r84564 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r84563‎ | r84564 | r84565 >
Date:21:42, 22 March 2011
Author:dale
Status:ok
Tags:
Comment:
fixed case for wgFFmpeg2theoraLocation
Modified paths:
  • /trunk/extensions/TimedMediaHandler/README (modified) (history)
  • /trunk/extensions/TimedMediaHandler/TimedMediaHandler.php (modified) (history)
  • /trunk/extensions/TimedMediaHandler/WebVideoTranscode/WebVideoTranscodeJob.php (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/TimedMediaHandler.php
@@ -45,7 +45,7 @@
4646 $wgOggThumbLocation = '/usr/bin/oggThumb';
4747
4848 // The location of ffmpeg2theora ( transcoding )
49 -$wgffmpeg2theoraLocation = '/usr/bin/ffmpeg2theora';
 49+$wgFFmpeg2theoraLocation = '/usr/bin/ffmpeg2theora';
5050
5151 // Location of the FFmpeg binary ( used to encode WebM and for thumbnails )
5252 $wgFFmpegLocation = '/usr/bin/ffmpeg';
Index: trunk/extensions/TimedMediaHandler/WebVideoTranscode/WebVideoTranscodeJob.php
@@ -288,13 +288,13 @@
289289 * ffmpeg2Theora mapping is much simpler since it is the basis of the the firefogg API
290290 */
291291 function ffmpeg2TheoraEncode( $file, $target, $options){
292 - global $wgffmpeg2theoraLocation;
 292+ global $wgFFmpeg2theoraLocation;
293293
294294 // Get the source:
295295 $source = $file->getFullPath();
296296
297297 // Set up the base command
298 - $cmd = wfEscapeShellArg( $wgffmpeg2theoraLocation ) . ' ' . wfEscapeShellArg( $source );
 298+ $cmd = wfEscapeShellArg( $wgFFmpeg2theoraLocation ) . ' ' . wfEscapeShellArg( $source );
299299 // Add in the encode settings
300300 foreach( $options as $key => $val ){
301301 if( isset( self::$foggMap[$key] ) ){
Index: trunk/extensions/TimedMediaHandler/README
@@ -85,7 +85,7 @@
8686
8787 Set the ffmpeg2theora binary location with:
8888
89 - $wgffmpeg2theoraLocation = '/path/to/ffmpeg2theora';
 89+ $wgFFmpeg2theoraLocation = '/path/to/ffmpeg2theora';
9090
9191 Download ffmpeg2theora from: http://firefogg.org/nightly/
9292

Status & tagging log